microsoft / microsoft/WinUI-Gallery
ColorSections: Hard-coded color values are a no-go
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.6k
- Forks
- 756
- Avg merge
- 17h 51m
- Merged PRs (30d)
- 14
Description
In WinUI-Gallery\WinUIGallery\Controls\DesignGuidance\ColorSections\ there are six pages, each containing hard-coded color values. Even though these aren't displayed in the ColorTile - because that TextBlock is commented - the hardcoded values simply shouldn't be there in the first place. Colors may (slightly) change over time, or there's a chance of a simple typo.
<local:ColorTile
Background="{ThemeResource TextFillColorSecondaryBrush}"
ColorBrushName="TextFillColorSecondaryBrush"
ColorExplanation="Rest or Hover"
ColorName="Text / Secondary"
ColorValue="#000000 (9E, 61.86%)"
Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}" />
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in WinUI-Gallery/WinUIGallery/Controls/DesignGuidance/ColorSections/ and inspect the six pages containing ColorTile elements. Remove the hard-coded ColorValue entries, then verify those pages no longer include the obsolete color values.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100