microsoft / microsoft/WinUI-Gallery
Imperfect looks on the Color controls
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.6k
- Forks
- 756
- Avg merge
- 17h 51m
- Merged PRs (30d)
- 14
Description
Which version of the app?
WinUI 3 Gallery
Description
Minor issue.
- In some occasions, it looks like the border of the ColorTile control and the child element(s) do not have the same CornerRadius, or a padding (?) that creates a border.
- In some occasions, it looks like 4px is used.
- In some (2) places,
CornerRadius="4"is used. Not only is it hard-coded, it's also the incorrect value for these cases.
Screenshots
[!NOTE]
A Grid with a CornerRadius (StyleGalleryTileGridStyleuses OverlayCornerRadius) does not clip the content. A Border does. That means we can envelope each Grid with a Border. the accompanying Style should then be set on the Border, in place of the Grid.Issue is: GalleryTileGridStyle is used throughout the DesignGuidance and Accessibility pages.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the ColorTile control and GalleryTileGridStyle, then locate its uses throughout the DesignGuidance and Accessibility pages. Compare the rendered borders, child elements, padding, and CornerRadius values against the screenshots; done means the affected Color controls have consistent, correct corners without hard-coded incorrect values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100