microsoft / microsoft/WinAppVSCE
Remove GH_TOKEN before executing downloaded WinApp CLI
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 3
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 11
Description
Describe the bug
The CI download step executes the freshly downloaded winapp.exe --version while GH_TOKEN remains in the process environment. The CLI release is a trusted first-party publishing input, and the workflow token is read-only, so this is defense-in-depth rather than an urgent supply-chain concern.
Unset GH_TOKEN before invoking the downloaded executable, or separate download and execution into steps so the execution step has no GitHub token.
To Reproduce
- Run
.github/workflows/build.yml. - The
Download CLI binariesstep setsGH_TOKEN. scripts/download-cli.ps1downloads the release and invokeswinapp.exe --versionin that same environment.
Expected behavior
Downloaded CLI binaries should execute without GH_TOKEN or other unnecessary credentials in their environment.
Screenshots
N/A
OS Version and details
GitHub Actions windows-latest
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/build.yml and scripts/download-cli.ps1, focusing on the Download CLI binaries step and the winapp.exe --version invocation. Adjust the workflow or script so the downloaded executable runs without GH_TOKEN, then rerun the Windows workflow and verify the command succeeds without unnecessary credentials in its environment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, powershell
- Domain
- ci-cd, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100