microsoft / microsoft/WinAppVSCE
[Bug]: Browse E2E does not verify native file selection
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 3
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 11
Description
Describe the bug
The winapp.sign Browse E2E smoke test only verifies that the QuickPick disappears and no immediate error notification appears. It does not prove that the native Open dialog was shown, that a selected path returns to the extension, or that the selected file reaches the signing flow. The existing Playwright path cannot interact with native Windows dialogs and is also timing-sensitive.
To Reproduce
- Run the Browse test in
src/test/e2e/sign-quickpick.spec.ts. - Observe that its assertions stop after QuickPick dismissal.
- A regression that dismisses the QuickPick without opening/handling the native dialog can still satisfy the assertions.
Expected behavior
Use the repository's UI Automation/driver-queue harness or an injectable picker adapter to verify that choosing Browse opens the native dialog and returns the selected file into the sign flow.
Screenshots
N/A
OS Version and details
Windows
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/test/e2e/sign-quickpick.spec.ts and inspect the repository's UI Automation/driver-queue harness or picker adapter. Trace the Browse action through the native Open dialog and back into the extension's signing flow. Done means the test verifies the dialog opens, a selected path returns, and that path reaches signing rather than only checking QuickPick dismissal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100