microsoft / microsoft/WPF-Samples
Bug parsing margins with cultures that have a comma as decimal separator instead of a point
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 5.7k
- Forks
- 3.3k
- Avg merge
- 12d 8h
- Merged PRs (30d)
- 2
Description
Line 268 of HtmlFromXamlConverter.cs should be updated like this to support other cultures:
if (double.TryParse(values[i], NumberStyles.Any, CultureInfo.InvariantCulture, out value))
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open HtmlFromXamlConverter.cs and inspect line 268, where margin values are parsed. Update the parsing to support cultures using a comma as the decimal separator, then verify that margin parsing works for those cultures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100