microsoft / microsoft/VFSForGit
Add more logging around unmounting repositories during upgrade
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
We had a user report about upgrade failing because of blocking processes. From the logs, it was not clear exactly what happened - it would be nice if we had enough logging here to diagnose these problems.
-
We know the blocking process ID, but we are not able to match it up to a specific mount. Maybe we should have the mount process log its PID, or include some other information to match the blocking mount.
-
We don't have much logging around what GVFS.Service thinks are the running mounts, or the exact mounts that it is trying to unmount. Including more information here might help us diagnose whether we failed to unmount an enlistment we expected to unmount, or whether there is an "unregistered" mount process.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the GVFS.Service upgrade and repository-unmounting paths, tracing how running mounts and blocking process IDs are currently logged. Review the upgrade failure logs and identify the mount process and service state information available there. Done means the logs associate blocking PIDs with mounts and show both expected running mounts and the exact mounts being unmounted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools, operating-systems
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100