microsoft / microsoft/VFSForGit

Mac: Do not invalidate the vnode cache for directory renames that do not cross virtualization root boundaries

Open
#933 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

affects: performance domain: kext platform: macOS
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

See discussions in #715 for additional context.

Currently the vnode cache will be invalidated when any directory rename occurs. The vnode cache only needs to be invalidated when a directory rename is across (either into or out of) a virtualization root.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the discussions in #715, then trace the directory-rename handling that invalidates the vnode cache on Mac. Confirm the behavior for renames within a virtualization root versus renames across a root boundary; done means invalidation occurs only for the latter cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, macos
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.