microsoft / microsoft/VFSForGit

AllowAllLocksNamedPipeServer should handle post index changed hook messages

Open
#929 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

platform: macOS platform: windows type: bug
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

The post index changed hook can be called during clone, and AllowAllLocksNamedPipeServer (which handles hook requests during clone) does not properly handle the request (the request gets handled by the default case of its message handler).

AllowAllLocksNamedPipeServer should have a case for handling post index changed message(s).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search for AllowAllLocksNamedPipeServer and its message handler, then inspect how post index changed hook messages are represented and handled during clone. Done means these messages no longer fall through to the default case; verify the relevant clone or hook handling tests if present.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, git
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.