microsoft / microsoft/VFSForGit
Mac: Create unit/integration tests covering kauth listener callbacks, then refactor
Open
@pmj is already working on this.
Since Mar 12, 2019.
domain: kext
platform: macOS
pr: refactoring
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
Issue #882 and its fix #886 highlighted that none of us are particularly happy with the code for HandleFileOpOperation and HandleVnodeOperation, as well as the helper functions TryGetVirtualizationRoot, ShouldHandleFileOpEvent, and friends. The code is hard to read, contains a lot of duplication with subtle differences, and thus is also error-prone.
We should first aim for good test coverage in these areas of code (currently it is essentially zero) and then use them to make structural changes to the code with confidence.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.