microsoft / microsoft/VFSForGit
gvfs upgrade crash
Open
Nobody has claimed this yet.
platform: windows
type: bug
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
GVFS Version: 1.0.18297.1
C:\Users\corepkg>gvfs upgrade --confirm
Checking for GVFS upgrades...Succeeded
New GVFS version 1.0.19060.1 available in ring Slow
Launching upgrade tool...
Installer launched in a new window. Do not run any git or gvfs commands until the installer has completed.
And then it crashes in the new window:
Downloading.../
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
at GVFS.Common.ProductUpgrader.TryDownloadAsset(Asset asset, String& errorMessage)
at GVFS.Common.ProductUpgrader.TryDownloadNewestVersion(String& errorMessage)
at GVFS.Upgrader.UpgradeOrchestrator.TryDownloadUpgrade(Version version, String& consoleError)
at GVFS.Upgrader.UpgradeOrchestrator.<>c__DisplayClass16_0.<TryRunUpgrade>b__0()
at GVFS.Common.ConsoleHelper.<>c__DisplayClass1_0.<ShowStatusWhileRunning>b__0()
at GVFS.Common.ConsoleHelper.ShowStatusWhileRunning(Func`1 action, String message, TextWriter output, Boolean showSpinner, String gvfsLogEnlistmentRoot, Int32 initialDelayMs)
at GVFS.Upgrader.UpgradeOrchestrator.LaunchInsideSpinner(Func`1 method, String message)
at GVFS.Upgrader.UpgradeOrchestrator.TryRunUpgrade(Version& newVersion, String& consoleError)
at GVFS.Upgrader.UpgradeOrchestrator.Execute()
at GVFS.Upgrader.Program.Main(String[] args)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing gvfs upgrade --confirm with the versions and Slow ring shown in the report. Read GVFS.Common.ProductUpgrader.TryDownloadAsset and the surrounding upgrade flow in TryDownloadNewestVersion; done means the upgrade no longer crashes with a NullReferenceException and completes successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100