microsoft / microsoft/VFSForGit
Rename the `ExpectedException` unit test attribute to something better
Open
Nobody has claimed this yet.
platform: macOS
platform: windows
pr: refactoring
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
As mentioned in https://github.com/Microsoft/VFSForGit/pull/879#discussion_r262273647, ExpectedException is not a good description of what the attribute controls or why it's been applied. Replace it with a better name.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in pull request 879, then search the repository for ExpectedException to find the attribute declaration and its usages. Choose a clearer name based on that discussion, rename the attribute and all references, and run the affected unit tests to confirm the rename is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100