microsoft / microsoft/VFSForGit
Downloads directory is not deleted after running `gvfs upgrade` and subsequent non-elevated `gvfs upgrade` commands report an error
Open
@jamill is already working on this.
Since Feb 22, 2019.
type: bug
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
- Upgrade VFS4G via
gvfs upgrade --confirm - Open a non-elevated CMD prompt and run
gvfs upgrade - The follow error is logged and reported via telemetry:
[2019-02-22 13:38:23 -08:00] Error {"ErrorMessage":"DeleteAllInstallerDownloads: Could not remove directory: C:\ProgramData\GVFS\GVFS.Upgrade\Downloads.System.ArgumentException: Access to the path is denied.\r\n at System.IO.FileSystemInfo.set_Attributes(FileAttributes value)\r\n at GVFS.Common.FileSystem.PhysicalFileSystem.RecursiveDelete(String path)\r\n at GVFS.Common.ProductUpgraderInfo.DeleteAllInstallerDownloads()"}
Two issues here:
- The downloads directory should have been deleted after the upgrade
gvfs upgradeshould not report an error ifDeleteAllInstallerDownloadsfails when running non-elevated (in fact it should probably not try to delete the directory at all).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.