microsoft / microsoft/VFSForGit
Consider setting minimum required Windows version to RS5 and Server 2019
Open
Nobody has claimed this yet.
affects: reliability
platform: windows
pr: refactoring
type: enhancement
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
If we were to require RS5+ we could potentially:
- Eliminate the need to ask GVFS.Service to attach the filter
- [Need to confirm] Remove the code that probes ProjFS to see if it's pattern matching works as expected https://github.com/Microsoft/VFSForGit/blob/bebe93b9db4e3b67b31dccb53296e78daa531322/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs#L257
- Remove the myget NuGet feed that is used for publishing the native ProjFS binaries
- Remove VFS4G's code for installing ProjFS if it's not present on the machine
- [Need to confirm]: Remove the code that checks for
FILE_RETURNS_CLEANUP_RESULT_INFOflag https://github.com/Microsoft/VFSForGit/blob/6d4cbde9f8e92ab0c72bc6e5cc4c14da5c288dfe/GVFS/GVFS.Platform.Windows/ProjFSFilter.cs#L314
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs and GVFS.Platform.Windows/ProjFSFilter.cs at the referenced locations. Confirm whether RS5 and Server 2019 make each listed attachment, probing, native-binary, installation, and cleanup-result compatibility path unnecessary; done means the required scope and minimum-version decision are established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100