microsoft / microsoft/VFSForGit

Windows: Ensure that merges that containing symlinks do not corrupt symlinks.

Open
#703 0 comments 0 reactions 1 assignee View on GitHub

@kewillford is already working on this.

Since Feb 8, 2019.

affects: correctness platform: macOS platform: windows pri2 priority: mac-next type: spike
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

#297 is open for full support of symlinks on Windows. Until that's ready, however, we should ensure that merging two branches where a symlink has changed works properly on Windows and does not corrupt the symlink.

Example

  1. On Mac: Create a branch in a repo containing a symlink
  2. Modify the symlink, commit the change, and push it to the server
  3. On Windows: Fetch the new branch
  4. Merge in the new branch and push it to the server
  5. On Mac: Fetch the (now merged) branch
  6. Confirm that the symlink is still a symlink

We should also test how Windows handles merge conflicts of symlinks (although adding support for the symlink merge conflict scenario likely falls under #297 rather than this issue).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.