microsoft / microsoft/VFSForGit

GVFS.Service crashed while no VFSForGit repos were mounted/present

Open
#656 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

platform: windows type: bug
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

On a lab machine that contained no VFSForGit cloned repositories, GVFS.Service crashed on startup. From the log:

[12/20/2018 11:58:34 AM] Error {"Area":"GVFSService","Exception":"System.NullReferenceException: Object reference not set to an instance of an object.\r\n at GVFS.Service.GVFSService.OnSessionChange(SessionChangeDescription changeDescription) in E:\A\_work\304\s\GVFS\GVFS.Service\GVFSService.cs:line 123","ErrorMessage":"Unhandled exception in OnSessionChange"}

All attempts to start the service succeeded before and after this occurrence, so whatever issue lead to the crash disappeared on reboot.

This is VFSForGit release 1.0.18297.1.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at GVFS/Service/GVFSService.cs line 123 and review the OnSessionChange path associated with the logged NullReferenceException. Investigate why startup can encounter a null value when no VFSForGit repositories are present, then verify that the service starts without crashing in that condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, git
Domain
backend, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.