microsoft / microsoft/VFSForGit
Mac: Use $NOCANCEL variant of close()
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
The errors returned by close() (and most likely fclose) are unreliable on Mac.
See discussions here:
https://github.com/rust-lang/libc/issues/595
https://bugs.chromium.org/p/chromium/issues/detail?id=269623
Both the user-mode ProjFS lib and VFS4G PInvokes should be updated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the user-mode ProjFS library and the VFS4G P/Invoke declarations mentioned in the issue, then review the linked libc and Chromium discussions about Mac close() behavior. Confirm where close() and fclose are used and what the $NOCANCEL variant requires. Done means both named areas use the appropriate Mac variant and their existing tests or checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100