microsoft / microsoft/VFSForGit
Mac: Include placeholder mtime in xattrs and check it when updating placeholders
Open
Nobody has claimed this yet.
affects: reliability
domain: user-mode
platform: macOS
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
Reduce the likelihood that PrjFS_UpdatePlaceholderFileIfNeeded deletes a user-modified file by:
- Storing the placeholder mtime (i.e. when it was created or hydrated) in the placeholder's xattrs.
- Checking the mtime in the xattrs against the mtime on the file in
PrjFS_UpdatePlaceholderFileIfNeededbefore deleting the file - Returning
PrjFS_UpdateFailureCause_FullFilefromPrjFS_UpdatePlaceholderFileIfNeededif the mtimes do not match.
TBD: Does updating our custom xattrs change the file's mtime? If so, this approach might not work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Mac implementation of PrjFS_UpdatePlaceholderFileIfNeeded and the placeholder xattr handling. Determine whether updating custom xattrs changes the file mtime, then compare the stored placeholder mtime with the file mtime before deletion. Done means mismatches return PrjFS_UpdateFailureCause_FullFile and user-modified files are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100