microsoft / microsoft/VFSForGit

Error "Received a release request from a process that does not own the lock" in Telemetry

Open
#474 10 comments 0 reactions 1 assignee View on GitHub

@kewillford is already working on this.

Since Dec 5, 2018.

affects: mount-reliability type: bug
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

We see several entries of "Received a release request from a process that does not own the lock" in the logs

From what I see the logs there appears to be a race condition where we detect a process is not longer running here and released it via the process gracefully ending.

In the entries I investigated we call

  • Microsoft.Git.GVFS.ExternalLockHolderExited
    followed quickly by
  • Microsoft.Git.GVFS.ReleaseLockHeldByExternalProcess

Looking at the times the actual git commands were running, the process has indeed exited. We should think about how we can clean this up in the logs to make sure we're logging true failures

@wilbaker let me know if my diagnosis sounds correct


[wilbaker] UPDATE

@kewillford was able to reproduce this:

Just had to create a local user that was not an admin and mounted with that user. Then run git commands as my admin user.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.