microsoft / microsoft/VFSForGit

Harden placeholder list persistence, and persist before writing placeholder

Open
#442 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

affects: reliability type: bug
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

(Copying from 1196804 in old backlog)

Currently VFS4G can lose track of a placeholder if either:

  1. There is a power loss before VFS4G attempts to write to the placeholder list (but after it has written the placeholder)
  2. There is a power loss before the placeholder list is flushed to disk

To address these issues:

  1. VFS4G should write to the placeholder list before writing the placeholder
  2. VFS4G should flush the file buffers for the placeholder list file

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating VFS4G's placeholder-list persistence and placeholder-write paths; the issue does not name specific files or tests. Trace the power-loss ordering and buffer-flush behavior, then verify that the placeholder list is persisted before the placeholder and flushed to disk.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.