microsoft / microsoft/VFSForGit

Mac: Investigate always walking to the root when notifying the provider of new folders

Open
#390 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

domain: user-mode platform: macOS
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

See conversation in #357

I'm just wondering here - should we break out, or keep going until we get to the virtualization root? Are there any valid scenarios where going all the way up would allow us to heal from some other missed notification, e.g. because of a power loss? (Also fine to say that is out of scope for now)

This issue is for investigating the above suggestion. Currently the code that sends new folder notifications stops walking up the tree as soon as it find a folder marked as in root. Would we be better always walking to the root>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the conversation in issue #357 and locate the code that sends new folder notifications. Investigate whether walking to the virtualization root can recover from missed notifications, then document the decision and implement the agreed notification behavior if a change is warranted.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
operating-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.