microsoft / microsoft/VFSForGit
[Code Refactoring] Move Repo mount/un-mount methods out of InstallerPreRunChecker
Open
Nobody has claimed this yet.
pr: refactoring
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
- InstallerPrerunChecker is a utility class that helps check the machine state and help decide whether product upgrade can be installed on the target machine.
- InstallerPrerunChecker, as the name implies is not supposed to change the state of the target machine, by mounting new gvfs repos or unmounting existing ones.
- The mount/re-mount methods used in InstallerPreRunChecker should be moved outside this class.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating InstallerPreRunChecker and its mount/re-mount methods, then inspect their callers and the surrounding upgrade-installation flow. Move the state-changing repository operations outside the checker while preserving the upgrade decision checks; done means InstallerPreRunChecker no longer mounts or unmounts GVFS repositories.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100