microsoft / microsoft/VFSForGit
Tracking: ProjFS regression with buffer resizing
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
While working on the GIt 2.29.0 update, we noticed that projections were failing to match vanilla Git when it came to the GVFlt_MoveFileTests/LongFileName folder. The root cause is that ProjFS updated recently in response to a security bug, but that fix included a change to how it handles resizing filename buffers.
With the help of @wilbaker and @cgallred, we discovered the root cause, and the ProjFS team is working on a fix.
In order to get us unblocked, we need to stop testing this scenario until ProjFS ships to the Azure Pipelines build machines.
- Remove the
GVFlt_MoveFileTests/LongFileNamefolder in the test repo (using new branchesFunctionalTests/20201014*) - Point VFS for Git functional tests to that branch, and ignore any tests that care about that folder. (#1697)
- Periodically check if we can revert that change to the functional tests.
- Revert the test changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Check whether the ProjFS fix has reached the Azure Pipelines build machines, then review the functional-test changes associated with #1697 and the FunctionalTests/20201014* branches. Done means confirming the LongFileName scenario can be restored and reverting the temporary test-repository and VFS for Git test changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, csharp, git
- Domain
- devops, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100