microsoft / microsoft/VFSForGit

Gvfs prefetch --hydrate not sparse aware

Open
#1,632 1 comment 0 reactions 1 assignee View on GitHub

@kewillford is already working on this.

Since Jan 23, 2020.

domain: sparse pri3
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

Repro:

  1. Gvfs sparse --set parentFolder/childA
  2. gvfs prefetch --hydrate --folders parentFolder

Expected:
Prefetch + hydrate everything in parentFolder/childA

Actual:
Fails because it tries to prefetch + hydrate everything in parentFolder, not just childA subfolder:

Authenticating...Succeeded
Querying remote for config...Succeeded
Configured cache server: Global (xxx)
Checking that GVFS is mounted...Succeeded
Fetching blobs and hydrating files from cache server...Failed. Run 'gvfs log D:\onew7' for more info.

Log files shows a bunch of instances of "Failed to read parentFolder\childB\xxxx"

Basically, it seems like gvfs prefetch --hydrate does not limit itself to the cone of folders specified in the sparse set - it tries to prefetch + hydrate everything and fails because the files aren't on disk.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.