microsoft / microsoft/VFSForGit

GVFS Sparse: have gvfs sparse failures caused by opened files write to stderr like file handle failures

Open
#1,583 0 comments 0 reactions 1 assignee View on GitHub

@kewillford is already working on this.

Since Nov 11, 2019.

domain: sparse pri2
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

A while back @kewillford surfaced the gvfs sparse error for the case that gvfs sparse is called and needs to dehydrate a folder that currently has an open file handle on it. We needed a way for our cli which will wrap gvfs sparse to be able to get the error text for what went wrong to be able to communicate it to the user/log it to telemetry. The way we decided was to have gvfs sparse output to stderr:

<folder/file causing issue>

Such as:

engtools The process cannot access the file 'D:\mono\src\engtools\qtstore' because it is being used by another process.

The ask here is to have gvfs sparse follow the same pattern for failure caused by a dirty git status. Such as:

engtools The file engtools/qtstore/dirs is currently open for edit
otools The file otools/proj/otools.project is currently open for add

Where engtools and otools have been identified as folders needing dehydration. Folders that had changed files that did not need dehydration would not be reported here.

Would this be possible?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.