microsoft / microsoft/VFSForGit
GVFS Mount fails if post-command git hook outputs anything to stdout
Open
@kewillford is already working on this.
Since Nov 4, 2019.
pri3
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
Repro:
- Add to user's .gitconfig:
[gvfs "clone"]
default-post-command = D:\post-command2.hooks
- Add D:\post-command2.hooks file with contents:
D:\post-command2.bat
3) Add D:\post-command2.bat hooks file with contents:
echo "blah"
4) unmount/remount repo.
- see error:
D:\mono\src>gvfs mount
Authenticating...Succeeded
Failed to determine GVFS timeout and max retries: Error while reading 'gvfs.max-retries' from config: "blah"
Expected: gvfs mount should only fail if a git hook returns a nonzero exit code (or, I suppose, writes to stderr).
Note that this is not planned to be included in office's workflow, it's just something weird I found that I wanted to make sure was noted! Assigned to kevin because I found it while dogfooding gvfs sparse, but feel free to reassign as necessary as it's not exactly related!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.