microsoft / microsoft/VFSForGit

GVFS Mount fails if post-command git hook outputs anything to stdout

Open
#1,564 0 comments 0 reactions 1 assignee View on GitHub

@kewillford is already working on this.

Since Nov 4, 2019.

pri3
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

Repro:

  1. Add to user's .gitconfig:
[gvfs "clone"]
	default-post-command = D:\post-command2.hooks
  1. Add D:\post-command2.hooks file with contents:

D:\post-command2.bat
3) Add D:\post-command2.bat hooks file with contents:

echo "blah"
4) unmount/remount repo.

  1. see error:
D:\mono\src>gvfs mount
Authenticating...Succeeded
Failed to determine GVFS timeout and max retries: Error while reading 'gvfs.max-retries' from config: "blah"

Expected: gvfs mount should only fail if a git hook returns a nonzero exit code (or, I suppose, writes to stderr).

Note that this is not planned to be included in office's workflow, it's just something weird I found that I wanted to make sure was noted! Assigned to kevin because I found it while dogfooding gvfs sparse, but feel free to reassign as necessary as it's not exactly related!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.