microsoft / microsoft/VFSForGit
Mac: Handle GetVNodeAttributes failures more gracefully
Open
@pmj is already working on this.
Since Aug 23, 2019.
affects: correctness
affects: reliability
domain: kext
platform: macOS
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
We've seen reports of GetVNodeAttributes failing in the vnodeOp path. Rather than simply logging an error and denying the I/O we should:
- Log the message at the
KEXTLOG_DEFAULTlevel for ENOENT errors rather than theKEXTLOG_ERRORlevel - Treat the vnode as if the IsInVirtualizationRoot flag is on in the vnodeOp path and off in the fileOp path (so that the kext proceeds to looking up the root in the vnode cache)
- Treat the vnode as being empty and rely on ProjFSLib to read the file flags (it's smart enough to not re-expand or re-hydrate directories/files)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.