microsoft / microsoft/VFSForGit
Log failures to create new log files to telemetry and the system log
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
We recently had a report that GVFS.Service was not staying up after being started on Windows.
This was eventually tracked down to an ACL issue with C:\ProgramData\GVFS\GVFS.Service\Logs. The incorrect ACLs resulted in an unhandled exception getting thrown when creating the service log file, and nothing about the error was logged to telemetry or the system event log (or os log on Mac).
This extra logging would help diagnose issues like this more quickly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at GVFS.Service's log-file creation path and inspect how telemetry, the Windows system event log, and the macOS OS log are currently written. Reproduce the ACL failure described for the service Logs directory; done means the failure is recorded in telemetry and the platform-appropriate system log instead of remaining unhandled and silent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100