microsoft / microsoft/VFSForGit
Fix races when running 'gvfs mount' on same repo at the same time
Open
@kewillford is already working on this.
Since Jul 26, 2019.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
There are races when 2 gvfs mount commands run at the same time. Currently the only protection is checking if the connection to the pipe is there but 2 commands could easily get the result that they are not able to connect and continue trying to mount.
This can come into play with automount if the user tries to mount while automount is starting to mount as well.
We could add something to the mount verb that would prevent another mount verb from running until the previous mount is done like a mutex on the path to the repo.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.