microsoft / microsoft/VFSForGit
Mac: Improve validation in PrjFS_UpdatePlaceholderFileIfNeeded and PrjFS_DeleteFile
Open
Nobody has claimed this yet.
affects: reliability
domain: user-mode
platform: macOS
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
PrjFS_UpdatePlaceholderFileIfNeeded
- Update the function to check if the contentId or fileMode have changed before proceeding with the update
- Confirm that races with file hydration are handled properly
PrjFS_DeleteFile
- Confirm that races with file hydration are handled properly
- Determine if we should check the XAttrs for directories as well
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PrjFS_UpdatePlaceholderFileIfNeeded and PrjFS_DeleteFile entry points. Review how each handles contentId, fileMode, file hydration races, and XAttrs for directories on Mac. Done means validation behavior and race handling are confirmed or corrected, with the directory XAttr decision resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, macos
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100