microsoft / microsoft/VFSForGit
Mac: Use umask() to reduce the number of calls to chmod() in PrjFS_WritePlaceholderFile
Open
Nobody has claimed this yet.
affects: performance
affects: reliability
domain: user-mode
platform: macOS
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
Currently PrjFS_WritePlaceholderFile calls chmod every single time it's called. If VFS4G were to use umask to set its default creation mask to 644 then PrjFS_WritePlaceholderFile would only need to call chmod for files that happen to have a different mode in the index.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Mac implementation of PrjFS_WritePlaceholderFile and inspect how it currently calls chmod on each invocation. Read the surrounding VFS4G creation-mask handling before assessing how umask could establish a default mode of 644. Done means the function avoids unnecessary chmod calls while preserving the indexed mode for files that differ.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, macos
- Domain
- operating-systems, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100