microsoft / microsoft/VFSForGit
Mac: Validate magic number and format in TryGetXAttr
Open
Nobody has claimed this yet.
affects: reliability
platform: macOS
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
Address the TODO here:
Most of the work in this issue is deciding what VFS4G should do if the validation fails. At a minimum a warning or error should be logged.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the TODO near line 1297 in ProjFS.Mac/PrjFSLib/PrjFSLib.cpp and trace how TryGetXAttr handles the returned magic number and format. Decide the behavior when validation fails, then ensure the failure produces at least the warning or error logging requested by the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100