microsoft / microsoft/VFSForGit
POSIX: Implement TryGetNormalizedPathImplementation and GetFinalPathName and properly handle firmlinks on Catalina
Open
@pmj is already working on this.
Since Aug 7, 2019.
affects: correctness
platform: linux
platform: macOS
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
We need to implement TryGetNormalizedPathImplementation (or verify that paths across symlinks work properly with the current implementation).
TryGetNormalizedPathImplementation should return the canonical path of a file.
public static bool TryGetNormalizedPathImplementation(string path, out string normalizedPath, out string errorMessage)
{
// TODO(POSIX): Properly determine normalized paths (e.g. across links)
errorMessage = null;
normalizedPath = path;
return true;
}
PATH_STRING GetFinalPathName(const PATH_STRING& path)
{
// TODO(Mac): Implement
return path;
}
Update (7/30/2019)
See also the discussion here:
https://github.com/microsoft/VFSForGit/pull/1337#discussion_r307829313
We need to make sure that firmlinks are handled properly and that could require changes to GetRelativePath in PrjFSLib as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.