microsoft / microsoft/VFSForGit
Add validation to RSLock and SpinLock mocks
Open
Nobody has claimed this yet.
affects: tests
domain: kext
platform: macOS
type: enhancement
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
Validating that the locks are used properly will help improve our coverage of the kext code.
For an example, see discussion here: https://github.com/microsoft/VFSForGit/pull/1193#discussion_r291294685
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the RSLock and SpinLock mock implementations and read the discussion in PR #1193, especially the linked discussion. Add validation that detects improper lock usage, then run the existing kext-related tests and confirm coverage exercises the validation paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100