microsoft / microsoft/VFSForGit

gvfs diagnose crash while creating archive

Open
#1,236 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
C#
Stars
6.1k
Forks
474
Avg merge
2d 4h
Merged PRs (30d)
8

Description

gvfs diagnose verb crashed while zipping the log files. The crash happens inside the compression library that it uses.

crash stack.txt

	clrcompression.dll!fill_window(internal_state * 0x0000022b31fa3320) Line 1319	C
	clrcompression.dll!deflate_slow(internal_state * 0x0000022b31fa3320, int 0) Line 1570	C
	clrcompression.dll!deflate(z_stream_s * 0x0000022b3564f450, int 0) Line 790	C
	System.ni.dll!00007ffc733d9cf6()	Unknown
	[Managed to Native Transition]	
>	System.dll!System.IO.Compression.DeflaterZLib.Deflate(System.IO.Compression.ZLibNative.FlushCode) Line 262	C#
	System.dll!System.IO.Compression.DeflaterZLib.ReadDeflateOutput(byte[], System.IO.Compression.ZLibNative.FlushCode, out int = 0) Line 185	C#
	System.dll!System.IO.Compression.DeflaterZLib.System.IO.Compression.IDeflater.GetDeflateOutput(byte[]) Line 166	C#
	System.dll!System.IO.Compression.DeflateStream.WriteDeflaterOutput(bool = false) Line 513	C#
	System.dll!System.IO.Compression.DeflateStream.Write(byte[], int, int) Line 490	C#
	System.IO.Compression.dll!System.IO.Compression.CheckSumAndSizeWriteStream.Write(byte[], int, int = 81920) Line 401	C#
	System.IO.Compression.dll!System.IO.Compression.ZipArchiveEntry.DirectToArchiveWriterStream.Write(byte[], int, int = 81920) Line 1197	C#
	mscorlib.dll!System.IO.Stream.InternalCopyTo(System.IO.Stream = {System.IO.Compression.WrappedStream}, int) Line 227	C#
	System.IO.Compression.FileSystem.dll!System.IO.Compression.ZipFileExtensions.DoCreateEntryFromFile(System.IO.Compression.ZipArchive, string, string, System.IO.Compression.CompressionLevel?) Line 207	C#
	System.IO.Compression.FileSystem.dll!System.IO.Compression.ZipFile.DoCreateFromDirectory(string, string, System.IO.Compression.CompressionLevel? = null, bool = false, System.Text.Encoding) Line 529	C#
	GVFS.exe!GVFS.CommandLine.DiagnoseVerb.Execute.AnonymousMethod__0() Line 179	C#
	GVFS.Common.dll!GVFS.Common.ConsoleHelper.ShowStatusWhileRunning.AnonymousMethod__0() Line 28	C#
	GVFS.Common.dll!GVFS.Common.ConsoleHelper.ShowStatusWhileRunning(System.Func<GVFS.Common.ConsoleHelper.ActionResult>, string = "Creating zip file", System.IO.TextWriter = {System.IO.TextWriter.SyncTextWriter}, bool, string = null, int = 0) Line 97	C#
	GVFS.exe!GVFS.CommandLine.GVFSVerb.ShowStatusWhileRunning(System.Func<bool>, string, string) Line 244	C#
	GVFS.exe!GVFS.CommandLine.DiagnoseVerb.Execute(GVFS.Common.GVFSEnlistment = {GVFS.Common.GVFSEnlistment}) Line 175	C#
	GVFS.exe!GVFS.Program.Main.AnonymousMethod__0_4(GVFS.CommandLine.GVFSVerb) Line 94	C#
	CommandLine.dll!CommandLine.ParserResultExtensions.WithParsed<GVFS.CommandLine.GVFSVerb>(CommandLine.ParserResult<object> = {CommandLine.Parsed<object>}, System.Action<GVFS.CommandLine.GVFSVerb>)	Unknown
	GVFS.exe!GVFS.Program.Main(string[]) Line 102	C#
	[Native to Managed Transition]	
	mscoreei.dll!_CorExeMain() Line 6420	C++
	mscoree.dll!_CorExeMain_Exported() Line 1223	C++
	kernel32.dll!BaseThreadInitThunk(unsigned long, long(*)(void *), void *) Line 64	C
	ntdll.dll!RtlUserThreadStart(long(*)(void *) 0x0000000000000000, void * 0x0000000000000000) Line 1163	C

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with GVFS.CommandLine.DiagnoseVerb.Execute around line 179 and the attached crash stack, which shows the failure during ZipFile.DoCreateFromDirectory and compression. Run the gvfs diagnose command to reproduce the archive-creation crash; done means the command completes without this crash.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.