microsoft / microsoft/VFSForGit
Consolidate common code in GVFS.Service Mac & Windows
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
GVFS.Service UT would probably be a lot cleaner if the common service code were moved into a new shared assembly (e.g. GVFS.Service.Common).
As it is now, it's a bit wonky because we're pulling in RepoRegistry from GVFS.Service.Mac (which makes it look Mac specific) when really it's common. By moving it to a common assembly we can have confidence that our unit tests are covering the RepoRegistry used on both platforms.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the GVFS.Service Mac and Windows projects and the GVFS.Service UT project, focusing on RepoRegistry and the current assembly references. Define the shared assembly boundary, move common service code there, and ensure the unit tests cover the RepoRegistry used by both platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100