microsoft / microsoft/VFSForGit
Move initialization code in `GVFSPlatform` to the Constructor
Open
Nobody has claimed this yet.
pr: refactoring
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
This can go into the Constructor.
public override IDiskLayoutUpgradeData DiskLayoutUpgrade { get; } = new MacDiskLayoutUpgradeData();
public override IKernelDriver KernelDriver { get; } = new ProjFSKext();
public override GVFSPlatformConstants Constants { get; } = new MacPlatformConstants();
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the GVFSPlatform class and inspect its constructor alongside the three property initializers shown in the issue. Move those initializations into the constructor while preserving the existing MacDiskLayoutUpgradeData, ProjFSKext, and MacPlatformConstants values; the work is done when the class behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100