microsoft / microsoft/VFSForGit
Consolidate ProcessLauncher/ProcessHelper
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 474
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
There are couple static Process launcher classes that are there today
- ProcessHelper - a static class in Common
- GVFS.Platform.POSIX and GVFS.Platform.Windows have static StartBackgroundProcess methods
Static classes make it difficult to mock them. Also there are a few classes that implement their own Process launchers. Consolidate the various Process classes into one single class and use it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ProcessHelper in Common, the GVFS.Platform.POSIX and GVFS.Platform.Windows StartBackgroundProcess methods, and the other classes that launch processes. Trace their callers and platform-specific behavior before deciding how they can share one mockable implementation. Done means the separate process-launching implementations are consolidated and callers use the single class; no tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100