microsoft / microsoft/TypeScript
Suggestion: Upper-bound generic type constraints
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
This is a proposal for generic structural supertype constraints.
I'll first detail the proposal, and then get into a discussion about use-cases.
Proposal
A supertype constraint is a constraint on a generic type parameter to be the structural supertype of another type. It's like a subtype/inheritance constraint, but from the other direction. For example, let's say we have a square:
interface Square {width : number; height : number}
In this suggested syntax, you could write:
performAction<T extended by Square>(partialSquare : T) {}
This means the type T must be a structural supertype of square. So the potential candidates for T are:
{width : number}, {height : number}, Square, {}
It's an established kind of type constraint, not something I just made up. Although it's not exactly common, some languages do implement this feature, such as Scala. In Scala, you can write:
def performAction[T >: Square](obj : T) = { ... }
To express a supertype/upper bound constraint. In this case, of course, the constraint isn't structural -- T must declare that it implements Square.
Utility
In most languages, including Scala, this kind of constraint isn't very useful. It only comes up in certain specific situations.
However, Javascript libraries often have this kind of API, where you're allowed to specify the partial properties of an object to modify it (the rest remain at their previous value).
In many cases, you can support this by having optional interface members, but isn't always possible or correct.
An important example is React, which defines a method called setState:
class Component {
var state;
setState(partialState) {
//merges the properties of partialState with the current state.
}
}
The right signature for this method should be:
class Component<Props, State> {
setState<PartialState extended by State>(partialState : PartialState) {
//merges the properties of partialState with the current state.
}
}
Currently,the definition files state that it is:
setState(fullState : State) {
//merges the properties of partialState with the current state.
}
Which doesn't fully capture the functionality of the method.
Notes
The suggested syntax doesn't give us a nice way of combining both subtype and supertype constraints. One possibility is:
exampleMethod<T extends LowerBound and extended by UpperBound>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides no file, test, or implementation entry point; begin by reading the proposal and its React setState example, then locate the generic-constraint and type-checking areas in the repository. Done would require agreed syntax and semantics for structural supertype constraints, including interaction with lower bounds, plus tests, but the issue does not define those details.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100