microsoft / microsoft/TypeScript

Add rule typescript.format.insertSpaceAfterOpeningAndBeforeClosingNamedImport

Open
#9,224 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: Formatter Help Wanted Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

From @unional on June 16, 2016 22:12

  • VSCode Version: 1.2.1
  • OS Version: Windows 2012 R2

Currently object literal will have space added, but not named import:

// before format code
import {Container} from './Container';

let x = {Container};

// after format code
import {Container} from './Container';

let x = { Container };

Copied from original issue: Microsoft/vscode#7795

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue's formatting example and trace where named imports are formatted and where existing object-literal spacing is handled. Add coverage for the requested rule and verify that enabling it spaces braces in named imports without changing unrelated formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.