microsoft / microsoft/TypeScript
DefinitionResponse selects full type range
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
When sending a definition request to the tsserver, the response contains a range selection of the whole type. For UX proposes it would be better to either select only the identifying portion, like a type name, or additional include such an identifying range.
See https://github.com/Microsoft/vscode/issues/6772 for some background.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the tsserver handling for DefinitionResponse and review the linked VS Code issue for the expected selection behavior. Determine whether the response should select only the identifying type portion or expose an additional identifying range; done means the chosen behavior is implemented and covered by the relevant definition-response tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers, developer-experience
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100