microsoft / microsoft/TypeScript
Rename symbol on a HTML tag inside of JSX globally renames all tags
Open
Nobody has claimed this yet.
Domain: JSX/TSX
Experience Enhancement
Suggestion
VS Code Tracked
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
From @xirzec on March 9, 2016 22:24
- Open a project that uses TypeScript + JSX (with react.d.ts loaded)
- Put the cursor over a common HTML tag like
<div> - Hit F2 to rename symbol
- Rename the div to something else (like span)
Expected: Just the matching open/close is renamed to <span>
Actual: Every div in every JSX file is now a span and even react.d.ts has had its div attribute in the HTML tag names renamed to span
VS Code version: 0.10.10
Copied from original issue: Microsoft/vscode#3937
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the four-step JSX rename scenario first, using a project with react.d.ts loaded. Then trace the JSX rename handling and verify completion by checking that only the matching opening and closing tags change, while other JSX files and react.d.ts remain untouched.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- compilers, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100