microsoft / microsoft/TypeScript

Add switch to disable _var unused variable prevention

Open
#63,143 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

🔍 Search Terms

leading underscore unused variable

✅ Viability Checklist
⭐ Suggestion

I always knew that _prefixed variables are ignored, but only recently I learned that it not only makes the IDE ignore unused variables, but it prevents the TS engine itself from even reporting whether a variable is used/unused to the IDE. I personally believe that a language engine should not be concerned by this and instead report everything raw and let the IDE and tooling handle it however the user wants.

What I want is to allow TS engine to compile without errors (if a variable is unused), but still report this information to the IDE and tooling.

Therefore, to not break existing codebases, I propose a new tsconfig flag to disable this implicit behavior.

With this new flag enabled, the TS engine will report whether a variable is used / unused to the IDE even if the variable name is prefixed with _.

This is especially useful in situations when one tries to avoid shadowing variable names, which could unknowingly lead to triggering this implicit behavior. And I am pretty sure that there is a myriad of other use cases where the loss of used/unused information is unwanted and unexpected.

const table = ...
// later
function replaceTable(_table) { // <- wrong, this variable is unused, but the IDE can't report this because of TS
  table = makeTable()
}

This setting does not affect noUnusedParameters, instead, they will work in tandem.

// tsconfig
noUnusedParameters: false,
reportUnusedUnderscoreVariables: true // <- just an adhoc placeholder

This will

  • allow tsc to compile even if there are unused variables
  • report unused variables prefixed with _ as unused to the IDE
  • show squiggles "unused variable" in the IDE
  • allow user to configure their tooling (eslint, etc.) to use regular expressions to selectively ignore their chosen variation and be not locked to using _name

related: https://stackoverflow.com/questions/79884683/what-is-causing-vs-code-to-ignore-prefixed-arguments-like-arg-ts6133

📃 Motivating Example

https://stackoverflow.com/questions/79884683/what-is-causing-vs-code-to-ignore-prefixed-arguments-like-arg-ts6133

I wrote a function that uses a column variable, but there was a column defined in the scope, so I renamed it to _column. Later, I encountered a bug and while investigating, I found that the variable was not used, but this fact was unknown to the IDE.

I have some unused parameters in other places, completely intentional, so I already disabled noUnusedParameters in tsconfig, because I don't use underscore _name to denote that a variable is unused. It's noise as I have IDE for that already.

💻 Use Cases
  1. What do you want to use this for?

I want to use variable names with underscore prefix to avoid shadowing existing variables, but I still want the IDE to report these variables to me for my consideration without breaking the build.

  1. What shortcomings exist with current approaches?

Regardless of the noUnusedParameters setting, the IDE will not receive information whether a variable is used/unused if it is prefixed with underscore.

  1. What workarounds are you using in the meantime?

There is no workaround.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing how TypeScript handles noUnusedParameters and suppresses unused-variable information for underscore-prefixed names, then compare compiler diagnostics with IDE/tooling reporting. Done means a configurable option preserves successful compilation while exposing those variables as unused to the IDE.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.