microsoft / microsoft/TypeScript

Plugin probe path starts in incorrect location?

Open
#62,618 2 comments 0 reactions 1 assignee View on GitHub

@sheetalkamat is already working on this.

Since Oct 17, 2025.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

The code to determine the global plugin search path is I think incorrect?

It joins the executing file path which includes the `typescript.js` or `tsserver.js` filename, with the `../../..` string which results in a path like: `X/node_modules/typescript/lib/tsserver.js/../../..` which means that the resultant path for this example is actually `X/node_modules` to which the resolve process appends a second `node_modules` folder resulting in looking for plugins in `X/node_modules/node_modules` so plugins never resolve.

```typescript
protected getGlobalPluginSearchPaths(): string[] {
// Search any globally-specified probe paths, then our peer node_modules
return [
...this.projectService.pluginProbeLocations,
// ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/node_modules/
combinePaths(this.projectService.getExecutingFilePath(), "../../.."),
];
}
```
https://github.com/microsoft/TypeScript/blob/main/src/server/project.ts#L2110

The actual resolve then happens here and the `node_modules` folder is appended:

```typescript
public static importServicePluginSync(
pluginConfigEntry: PluginImport,
searchPaths: string[],
host: ServerHost,
log: (message: string) => void,
): PluginImportResult {
Debug.assertIsDefined(host.require);
let errorLogs: string[] | undefined;
let resolvedModule: T | undefined;
for (const initialDir of searchPaths) {
const resolvedPath = normalizeSlashes(host.resolvePath(combinePaths(initialDir, "node_modules")));
log(`Loading ${pluginConfigEntry.name} from ${initialDir} (resolved to ${resolvedPath})`);
const result = host.require(resolvedPath, pluginConfigEntry.name); // TODO: GH#18217
if (!result.error) {
resolvedModule = result.module as T;
break;
}
const err = result.error.stack || result.error.message || JSON.stringify(result.error);
(errorLogs ??= []).push(`Failed to load module '${pluginConfigEntry.name}' from ${resolvedPath}: ${err}`);
}
return { pluginConfigEntry, resolvedModule, errorLogs };
}
```
https://github.com/microsoft/TypeScript/blob/main/src/server/project.ts#L500

I believe this may be the root cause of a number of different issues raised here:
https://github.com/microsoft/TypeScript/issues/61584
https://github.com/microsoft/TypeScript/issues/44289

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.