microsoft / microsoft/TypeScript

5.8.3 - Big repo with complex types in Angular - Maximum call stack size exceeded

Open
#62,415 6 comments 0 reactions 0 assignees View on GitHub
Needs More Info
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

### 🔎 Search Terms

max call stack size

### 🕗 Version & Regression Information

- I was unable to test this on prior versions because of custom code on our end

### ⏯ Playground Link

_No response_

### 💻 Code

We use a custom version of TypeScript, here are our changes, all the changes are similar, we just changed the values and the version of TS to publish it on our Azure DevOps

src/compiler/checker.ts
```ts
...
19126 if (tailCount === 5e4) {
...
20365 if (instantiationDepth === 5e3 || instantiationCount >= 5e8) {
...
```

lib/_tsc.js
```js
...
61663 if (tailCount === 5e4) {
...
62704 if (instantiationDepth === 5e3 || instantiationCount >= 5e8) {
...
```

lib/typescript.js
```js
...
66273 if (tailCount === 5e4) {
...
67314 if (instantiationDepth === 5e3 || instantiationCount >= 5e8) {
...
```

As for our repository I could share it somewhere under some NDA because the error depends probably on the size and the complexity of the types.

### 🙁 Actual behavior

```
RangeError: Maximum call stack size exceeded
at ...\node_modules\typescript\lib\typescript.js:72137:242
at map (...\node_modules\typescript\lib\typescript.js:2491:19)
at inferTypesFromTemplateLiteralType (...\node_modules\typescript\lib\typescript.js:72137:224)
at inferToTemplateLiteralType (...\node_modules\typescript\lib\typescript.js:72590:23)
at inferFromTypes (...\node_modules\typescript\lib\typescript.js:72364:9)
at inferTypes (...\node_modules\typescript\lib\typescript.js:72209:5)
at structuredTypeRelatedToWorker (...\node_modules\typescript\lib\typescript.js:69945:13)
at structuredTypeRelatedTo (...\node_modules\typescript\lib\typescript.js:69474:21)
at recursiveTypeRelatedTo (...\node_modules\typescript\lib\typescript.js:69425:19)
at isRelatedTo (...\node_modules\typescript\lib\typescript.js:68843:122)
```

### 🙂 Expected behavior

All this used to work with 5.4.5 but it does not with 5.8.3

### Additional information about the issue

We always had problems with complex types in TypeScript in our project which is pretty big (which also makes us question if it is really suited for bigger projects...).
We have experienced a lot of `Type instantiation is excessively deep and possibly infinite` errors and it's not clear which types cause them or how to solve the issue.
So we resolved to "hacking" TypeScript by using a custom version of 5.4.5 where we bumped up the values of `tailCount`, `instantiationDepth` and `instantiationCount` to fit our needs and everything was working with Angular 17 and 18, when we tried upgrading to Angular 19 with TypeScript 5.8.3 "hacked" we get the Error above.

Contributor guide

Open the contributing guide

Research direction

The report points to src/compiler/checker.ts and the generated lib/typescript.js and lib/_tsc.js, with the stack entering inferTypesFromTemplateLiteralType and related inference functions. First reduce the private Angular repository case to a public reproduction and compare TypeScript 5.4.5 with 5.8.3. Done means the reproduction no longer causes a maximum call stack error while retaining the expected type-checking behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.