microsoft / microsoft/TypeScript

Grammar checking errors should be reported during binding phases instead of type-checking phase

Open
#6,107 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Committed Suggestion VS Code Tracked
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

From @StrongRef on December 15, 2015 9:32

When declaring an octal literal, an error is shown.
error1

However, if another error is introduced, the error for octal literal usage is omitted.
error2

Another strict rule violation, this time both errors are visible.
error3

I could like into this one, just want to make sure this is an actual error.

Copied from original issue: Microsoft/vscode#1318

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the octal-literal case described in the issue, first alone and then alongside another error, and compare it with the strict-rule example. Trace the compiler's binding and type-checking phases; done means the grammar error remains reported during binding even when another type-checking error is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.