microsoft / microsoft/TypeScript
private fields in nested classes should have separate types?
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
🔍 Search Terms
typescript private field nested class
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
Private fields of a wrapper class are similar to symbols: perhaps the nested classes could have their own types for the fields based on the value they initialize in their constructor:
📃 Motivating Example
Plain JS:
class Friends {
#priv
Foo = class Foo extends Friends {
constructor() {
super()
this.#priv = 456 // <----------- number
}
fooMethod() {
console.log(this.#priv)
}
}
Bar = class Bar extends this.Foo {
constructor() {
super()
this.#priv = "789" // <-------------- string
}
barMethod() {
console.log(this.#priv)
}
}
}
const {Foo, Bar} = new Friends()
const f = new Foo()
const b = new Bar()
f.fooMethod() // logs "456"
b.barMethod() // logs "789"
💻 Use Cases
Allows having a "private" key to use on multiple classes, but each class could have a different type of value.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked TypeScript Playground example and review how private fields in nested classes and their inherited classes are currently checked. The issue names no source files or tests; done would require an agreed type-system design plus implementation and tests for the proposed separate field types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100