microsoft / microsoft/TypeScript
Inconsistent types between Document scrollingElement and documentElement
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
🔎 Search Terms
I think document.scrollingElement should be of type Document["documentElement"] | null instead of Element | null. The spec (e.g. this and this) says that in standards mode scrollingElement returns the document root, which is document.documentElement and in quirks mode returns document.body or null.
document.body is always HTMLElement (right?) In principle, document.documentElement does not have to be HTMLElement (and there's an open issue about this, #29052, but currently Document.documentElement is still defined as HTMLElement, for some reason. So how come document.scrollingElement is not HTMLElement | null?
🕗 Version & Regression Information
N/A
⏯ Playground Link
No response
💻 Code
// Your code here
🙁 Actual behavior
document.scrollingElement is of type Element | null whereas document.documentElement and document.body are both of type HTMLElement.
🙂 Expected behavior
The non-null part of document.scrollingElement should be the same type as document.documentElement, which technically should be Element, but if document.documentElement is left as HTMLElement, as is currently, then document.scrollingElement should also be this.
Additional information about the issue
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.