microsoft / microsoft/TypeScript

Type Instantiation is Excessively Deep Error Regression in #37348

Open
#60,567 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: check: Type Circularity Help Wanted
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

🔎 Search Terms

type instantiation is excessively deep, unused type parameter, unused tuple element, #37348

🕗 Version & Regression Information

This changed in PR #37348

⏯ Playground Link

https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEkoGdnwPoEkB2AXEM2UEAKgJ4AOIAIlLlALID2oE8A3gFDw-wVwVYNAgEsAbiGC16ALngBtKNjIAaeErIBdANycAvrs6gkcRNFTxyVaYxYgIAHm68A9C-iYAZvFwALEWi4lAiCMFAAtiD4MPAB8KxRkj6+CGAiMGAArtAwIkHwAOZMIGhQAO5QZAB0zjwAqtiZyJIqtfDUohJSdFCtAHzwIAAe+NjAaFh4BESkwTbMrBxt-CChwrldNnJ+ccOj45ZzPQv2DhpqItieBO2dkjZ9bbzwAPzwbpb+aM1gTGODEBAkTwsWwyQQuEyFEBsVKEGQTHg2HAJWQsDI8E8TBiCMi8DgKD+NWeJN48h2yDUGk0T14cg0uj0QA

💻 Code
declare class _InternalTypeDataModel {
    prepareDerivedData: [any, any];
};

declare class TypeDataModel<
    // If this type parameter is deleted the circularity goes away.
    Unused,
    DerivedData,
> extends _InternalTypeDataModel {
    prepareDerivedData: this extends TypeDataModel<any, infer DerivedData>
        ? // This second element in the tuple is also necessary for some reason.
            [this, any]
        : any;
}
🙁 Actual behavior
Type instantiation is excessively deep and possibly infinite.
🙂 Expected behavior

No error.

Additional information about the issue

I understand the weirdness in this minimized code but the actual code I was reducing actually does useful things and doesn't really seem so contrived in context. In actual code all type parameters and tuple elements actually do useful things but this reproduction shows it doesn't matter if they're used, just that they exist, for some reason.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided Playground reproduction and compare its behavior with the change introduced by PR #37348. Trace the type-instantiation path responsible for the excessive-depth diagnostic, then verify that this example and the reported regression no longer produce an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.