microsoft / microsoft/TypeScript

No file ending when adding import

Open
#60,451 2 comments 2 reactions 1 assignee View on GitHub

@andrewbranch is already working on this.

Since Nov 26, 2024.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

  • vscode at commit f0a00378912f27f30509fe8230abcfdf5b58a7c3
  • open src/vs/workbench/contrib/chat/browser/chatEditorOverlay.ts
  • on line 42 write this._editor.getOption(EditorOption) and make sure to use auto complete with import for EditorOption
  • 🐛 the import will be without .js

excerpt from the logs

Info 10477[09:55:25.163] response:
    {"seq":0,"type":"response","command":"updateOpen","request_seq":303,"success":true,"body":true}
Info 10478[09:55:25.214] request:
    {
      "seq": 304,
      "type": "request",
      "command": "updateOpen",
      "arguments": {
        "changedFiles": [
          {
            "fileName": "/Users/jrieken/Code/vscode/src/vs/workbench/contrib/chat/browser/chatEditorOverlay.ts",
            "textChanges": [
              {
                "newText": "import { EditorOption } from '../../../../editor/common/config/editorOptions';\n",
                "start": {
                  "line": 21,
                  "offset": 1
                },
                "end": {
                  "line": 21,
                  "offset": 1
                }
              }
            ]
          }
        ],
        "closedFiles": [],
        "openFiles": []
      }
    }

tsserver.log

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.