microsoft / microsoft/TypeScript

Mixin with abstract class infers wrong type for super

Open
#60,315 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: classes Help Wanted
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔎 Search Terms

"mixin abstract super", "mixin abstract super type", "mixin abstract constructor super", "mixin abstract constructor super type", "mixin Abstract method cannot be accessed via super expression"

🕗 Version & Regression Information
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about "super"
⏯ Playground Link

https://www.typescriptlang.org/play/?ts=5.7.0-dev.20241022#code/IYIwzgLgTsDGEAJYBthjAgsgTwILmjggGFV0EBvAKAQQAcBXEZAS1gVEhngQHMBTCADlgAW34AKAJQAuBFxYA7XgG4qAXypUAZg0XwWAe0UJRLAB5KA6iwgALfFyKk0YADwAVAEJp+CfuYQ-IoAJhiK-ADuCBIAdPHAULxgcsCK2ADaALpSCAC8AHxYeATcJGRgBRIA+iC+ct6+udQ0SBVYFkou5AFBoRi1vpRatLSMzGx8giLi0nIKysOjo1CCDFAmYAx0-FCxAsJiklIqCAD0ZwgAolBQhlByAESOhDzi9oYhCADkBzP83wQSjarh+OBeZW6YEBsDSikMiBAfjgsH46H4XwAbixgPJtrt-OY6Kt0EZFLFHq1aJpqSMEKsIOsTJhOoooWpNFoqEoglBtHA-DgAJKKXn81FLKaHWayeTQJSqDRaXT6CBk0ysmz2EVigWeHxgPy9YJhBARaJxBJJFIcdLZXKFYo63bi-hVQaGhoG-jNOkoUEsyxs9rG-oID1+FrLcasdh-I5zOVQBWS5YMpl4nZ7eMy04XBCRe4AazAVIQNPLdPTGw6QfZGiAA

💻 Code
abstract class MyAbstractClass {
  public abstract getName(): string;
}

function mixinWithAbstractClass<TBase extends new (...args: any[]) => MyAbstractClass>(_base: TBase) {

  class MixinClass extends _base {
    public getName(): string {
      return super.getName(); // Error: "Abstract method 'getName' in class 'MyAbstractClass' cannot be accessed via super expression."
    }
  }

  return MixinClass;
}



interface MyInterface {
  getName(): string;
}

function mixinWithInterface<TBase extends new (...args: any[]) => MyInterface>(_base: TBase) {

  class MixinClass extends _base {

    public getName(): string {
      return super.getName(); // works as expected
    }
  }

  return MixinClass;
}
🙁 Actual behavior

mixinWithAbstractClass fails because the compiler infers that super is of the exact type class MyAbstractClass.

🙂 Expected behavior

I expected mixinWithAbstractClass to compile like mixinWithInterface does. The constraint TBase extends new (...args: any[]) => MyAbstractClass specifies that TBase extends a concrete constructor, which returns instances that conform to MyAbstractClass. Since the constructor is concrete, we can infer that TBase (the superclass) already implements the abstract methods.

Additional information about the issue

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript Playground reproduction and compare the mixinWithAbstractClass and mixinWithInterface cases, focusing on how the compiler determines the type of super. Trace the type-checking path for abstract methods in a generic class extending _base; done means the abstract-class mixin accepts super.getName() without regressing the interface case, with a regression test for the reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.